Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestEnv doesn't play well with 1.9's weak dependencies #60

Open
haberdashPI opened this issue Jun 1, 2023 · 4 comments
Open

TestEnv doesn't play well with 1.9's weak dependencies #60

haberdashPI opened this issue Jun 1, 2023 · 4 comments

Comments

@haberdashPI
Copy link

haberdashPI commented Jun 1, 2023

I've noticed that when using TestEnv, package extensions (a new feature in 1.9) do not get loaded when a weak dependency is loaded. (Works fine when I run tests normally).

I assume that this is a feature that hasn't been implemented yet in TestEnv.

@oxinabox
Copy link
Member

oxinabox commented Jun 2, 2023

Yep, we will need to identify and port over that code.

@oxinabox
Copy link
Member

oxinabox commented Jun 2, 2023

Looks like #53 was incorrect and we will need to split those again.

@oxinabox
Copy link
Member

oxinabox commented Jun 2, 2023

I can't see anything obvious in https://github.com/JuliaLang/Pkg.jl/pull/3264/files#diff-5139153dfc15595c21d138e94a8641dd57bd6863cb2fdcc52a1d90a715da5ee8
I suspect there is another follow up PR that made all weakdeps into strong deps for testing

@haberdashPI
Copy link
Author

I noticed the problem I was running into was actually because I called TestEnv.activate() after using MyPackage. If I do it in the other order the extensions do get loaded. 😬 Sorry for the noise. (Perhaps there is another issue once they load, I haven't checked).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants