Use trailing dash (e.g. v"1.4-") to compare minor version numbers
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 74.31% 74.31%
=======================================
Files 25 25
Lines 623 623
=======================================
Hits 463 463
Misses 160 160
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oxinabox
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes minor version checks such as
VERSION >= v"1.4"(intended to match versions in the 1.4 series and beyond) to use Julia's trailing dash syntax:VERSION >= v"1.4-".The trailing dash is necessary for Julia's implementation of semver because
VERSION >= v"1.4"will returnfalsefor alpha, beta, and rc versions that are part of the 1.4 series (and therefore have the same features):Reference: https://docs.julialang.org/en/v1/manual/strings/#man-version-number-literals
This might fix #35 and/or #47.