Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace our integration test helpers with MetaTesting.jl #58

Open
nickrobinson251 opened this issue May 18, 2023 · 0 comments
Open

Replace our integration test helpers with MetaTesting.jl #58

nickrobinson251 opened this issue May 18, 2023 · 0 comments
Labels
refactor an internal change tests Related to testing of ReTestItems.jl itself

Comments

@nickrobinson251
Copy link
Collaborator

nickrobinson251 commented May 18, 2023 •
edited

The helpers we use to test ReTestItems.runtests were adapted from similar helpers in ChainRulesTestUtils (JuliaDiff/ChainRulesTestUtils.jl#62) which Seth kindly moved to a new package: https://github.com/sethaxen/MetaTesting.jl

If that package offers the functionality we need, then we could switch to it and not have to maintain our own helpers... plus then we can test our testing package with test helpers that are tested, which would be just lovely, wouldn't it?

We'd need JuliaTesting/MetaTesting.jl#2 + JuliaTesting/MetaTesting.jl#3 :)
I'm sure PRs would be welcome over there (we'd probably just need to agree on names for these functions)
@nickrobinson251 nickrobinson251 added refactor an internal change tests Related to testing of ReTestItems.jl itself labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor an internal change tests Related to testing of ReTestItems.jl itself
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickrobinson251