Check package extensions as well (julia 1.9+) #162
+213
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 77.07% 76.22% -0.85%
==========================================
Files 11 11
Lines 724 795 +71
==========================================
+ Hits 558 606 +48
- Misses 166 189 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lgoettgens
force-pushed
the
lg/check-extensions
branch
from
67e2869
to
db4a0aa
Compare
lgoettgens
force-pushed
the
lg/check-extensions
branch
from
db4a0aa
to
067e6ac
Compare
lgoettgens
force-pushed
the
lg/check-extensions
branch
from
2606b31
to
0496961
Compare
|
Testing all of this seems to be rather difficult, as package extensions do not work well with local packages given by relative paths. So I will skip tests. |
|
Ambiguity tests are now included as explained in #160. |
|
This would be great to have as we see more and more extensions being added :) Any plans to update and merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160.
Please see the discussion on the extend of this PR there.
For my convenience, this currently contains #156. Once that is merged, I will rebase.