Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celestrak rework #2

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Celestrak rework #2

merged 6 commits into from
Aug 3, 2023

Conversation

jmurphy6895
Copy link
Contributor

  • Grab F10.7 Flux, Ap and Kp indices, derived metrics and some solar indices from Celestrak SW instead of Fluxtable and Kp_ap_Ap_SN_F107_since_1932.
  • Added kwargs flag to urls() to give option to pull last 5 years of data or the entire history since 1957 from Celestrak
  • Also shifted F10.7 flux 8 hours since the metric is measured at 20:00
  • Fixed Test in JB2008 Indices that was failing

@ronisbr
Copy link
Member

ronisbr commented Aug 2, 2023

Hi @jmurphy6895 !

This PR is awesome! Thank you very much. I just have some comments related to code styling that I can change myself :)

I will merge as soon as the tests pass.

@ronisbr
Copy link
Member

ronisbr commented Aug 2, 2023

By the way, I am testing the code here, the file SW-All.csv has just 2.6 MiB. Should we really add that keyword all_history just for the Celestrak file? Wouldn't be better to keep the API simple and just download everything? What do you think?

@ronisbr
Copy link
Member

ronisbr commented Aug 3, 2023

Awesome! Thanks @jmurphy6895 ! Let's see if tests pass. I have no further comment.

@ronisbr ronisbr merged commit cb77132 into JuliaSpace:main Aug 3, 2023
10 checks passed
@ronisbr
Copy link
Member

ronisbr commented Aug 3, 2023

Done! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants