force specialization in sv_ecef_to_ecef #2
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that I had unexpected allocations when using the SatelliteToolbox ecosystem and I pinpointed this down to the
sv_ecef_to_ecef
function.This small PR tries to force specialization for this function as the generic
args...
can often lead to allocations due to lack of specialization (see this section of the performance tips)A benchmark of the function before and after this PR on my linux machine gives the following improvement:
Test code (taken from package tests)