new function: sun_position_el #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for sun positions in eq. and local coordinates.
|
Hi @spacenewb ! This is awesome! Thanks! Currently, I am revamping the SatelliteToolbox.jl ecosystem, splitting it in small packages (check this org: https://github.com/JuliaSpace). However, we can work on this PR and I refactor it into the new package when it is ready. This first thing I would like to ask you is to read the BlueStyle and refactor this PR to follow it as much as you can. This style is the one we selected for the SatelliteToolbox.jl. |
Computation of `Dt` in the function was wrong. Also fixed a little bit of formatting to conform to "BlueStyle"
|
Hi @spacenewb! I finished the code migration. Can you please move this PR to https://github.com/JuliaSpace/SatelliteToolboxCelestialBodies.jl ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
For sun positions in equatorial and local coordinates.
Suggested by: #3 (comment)
Note:
Needs polishing, and better integration with the source code, documentation, and tests.
This is my first-ever open-source contribution. Sorry for any mistakes.