Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider breaking out components? #1

Closed
crbinz opened this issue May 14, 2018 · 3 comments
Closed

Consider breaking out components? #1

crbinz opened this issue May 14, 2018 · 3 comments

Comments

@crbinz
Copy link
Contributor

crbinz commented May 14, 2018

Hi,

Congrats on the nice package, there is a lot of really great stuff in here! Have you considered moving things into smaller, dedicated packages? For instance, just from a quick browse of the code, I think the following components would lend themselves well to being standalone packages:

  • Geomagnetic field
  • Gravity field
  • the pure julia sgp4
  • potentially the frame transformations

I think most of these would also be useful to people who do not necessarily have interest in satellite mission analysis, and who otherwise would not know this functionality exists.
@ronisbr
Copy link
Member

ronisbr commented May 14, 2018

Hi @crbinz !

Thanks :)

Great suggestion. This package was originally used only inside INPE and, since it was not at METADATA, people had to clone the private repository manually. In this case, it seemed reasonable to have just one big package.

After the registration in METADATA, I will add some functionality that we already have but need to be ported to Julia and then I will start to think how can I break this package into smaller ones.

For sure, the frame transformations, IGRF, EGM, and SGP4 can go to standalone packages.

@crbinz crbinz mentioned this issue Oct 21, 2019
Merged
ronisbr pushed a commit that referenced this issue Nov 3, 2019
@crbinz @ronisbr
✨ Create SGP4 submodule
a4f90bd 
The SGP4 algorithm was moved to a submodule.

This partially addresses #1.

* Extricate SGP4 implementation as a submodule

* Copy GMST functions into SGP4 submodule

* Completely move TLE definition into SGP4 submodule

* Don't need to prefix submodule name

* Remove duplicate include statement

* Add Reexport dependency

* Rearrange SGP4 submodule files

* Untrack Manifest, accidentally added in 56c7b1

* Somehow I copied an old version of the SGP4 code, fix that

* Reorganize tests to accomodate SGP4 submodule

* Remove unneeded submodule prefix

* Do not export functions that are also in the main module
@ronisbr ronisbr mentioned this issue Apr 26, 2020
Closed
@ronisbr ronisbr mentioned this issue Nov 6, 2021
Open
@ronisbr ronisbr closed this as completed in a8d6175 Jul 2, 2023
@ronisbr
Copy link
Member

ronisbr commented Jul 2, 2023

Hi @crbinz !

I finally could fix this very old issue :) Now, the ecosystem is split in smallr packages. If you install this one, it will install, load, and reexport all of them.

Thanks for the proposal and sorry for the delay :)

@crbinz
Copy link
Contributor Author

crbinz commented Jul 3, 2023

Bravo! I think this is great for usability and extensibility. I hope I will get some time to experiment with it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronisbr @crbinz