Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for evaluation of constraints of an unconstrained model #465

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jun 18, 2024

Close #464

@tmigot
Copy link
Member Author

tmigot commented Jun 18, 2024

@dpo this is still ongoing, but what do you think of this?

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
ExaModels.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
MadNLP.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsModifiers.jl
NLPModelsTest.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverCore.jl
SolverTest.jl
SolverTools.jl

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmigot That looks good to me, thanks! I just made a few minor comments.

src/nlp/utils.jl Outdated Show resolved Hide resolved
src/nlp/utils.jl Outdated Show resolved Hide resolved
src/nlp/utils.jl Outdated Show resolved Hide resolved
src/nlp/api.jl Outdated Show resolved Hide resolved
@tmigot tmigot requested a review from dpo June 22, 2024 15:12
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good after these minor comments. Thank you.

src/nlp/utils.jl Outdated Show resolved Hide resolved
src/nlp/utils.jl Outdated Show resolved Hide resolved
test/nlp/dummy-model.jl Outdated Show resolved Hide resolved
test/nlp/dummy-model.jl Outdated Show resolved Hide resolved
@tmigot tmigot closed this Aug 9, 2024
@tmigot tmigot reopened this Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (d6e949f) to head (21cb8aa).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   99.25%   98.16%   -1.10%     
==========================================
  Files          13       13              
  Lines         807      872      +65     
==========================================
+ Hits          801      856      +55     
- Misses          6       16      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint evaluation behavior for unconstrained problems
2 participants