-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error for evaluation of constraints of an unconstrained model #465
base: main
Are you sure you want to change the base?
Conversation
@dpo this is still ongoing, but what do you think of this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmigot That looks good to me, thanks! I just made a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good after these minor comments. Thank you.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 99.25% 98.16% -1.10%
==========================================
Files 13 13
Lines 807 872 +65
==========================================
+ Hits 801 856 +55
- Misses 6 16 +10 ☔ View full report in Codecov by Sentry. |
Close #464