Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail because hash(:F) != hash(:F, UInt(0)) #25

Closed
gafter opened this issue Mar 15, 2023 · 1 comment
Closed

Tests fail because hash(:F) != hash(:F, UInt(0)) #25

gafter opened this issue Mar 15, 2023 · 1 comment
Assignees

Comments

@gafter
Copy link
Member

gafter commented Mar 15, 2023

The tests assume that hash(:F) is the same value as hash(:F, UInt(0)). That has not been the case since Julia added an optimization for the former:

hash(x::Symbol) = objectid(x)

Since the generated code uses the latter, the tests that verify the generated hash code should also use the former for comparison.

(Please assign this to me, or let me know if there is a new home for this macro)

@gafter
Copy link
Member Author

gafter commented Aug 18, 2023

Tests are now passing.

@gafter gafter closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant