Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate splitting factor operational part from 'constant' part of factor #992

Open
10 tasks
Affie opened this issue Mar 23, 2023 · 1 comment
Open
10 tasks

Comments

@Affie
Copy link
Member

Affie commented Mar 23, 2023

If it can be split so that factor solver data only contains the working memory serialization becomes easy as solver data is just ignored and rehydrated when unpacked for use by the solver and there can possibly be no PackedFactor.

'constant' in this case means not changed by the solver

In other words:
Should we move non FactorOperationalMemory to DFGFactor:
Maybe: fnc, multihypo, nullhypo, inflation ?
that way we split solverData <: FactorOperationalMemory and constants

@Affie
Copy link
Member Author

Affie commented Mar 3, 2025

Note on CCW: currently, only hyporecipe.certainhypo and usrfnc! are pulled out of CCW to be persisted, the rest are thrown away.
Also code TODO: improve _createCCW for hypotheses and certainhypo field recovery when deserializing reconstitute from stored data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant