Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad test now errors #99

Closed
KristofferC opened this issue Apr 18, 2024 · 2 comments · Fixed by #100
Closed

Bad test now errors #99

KristofferC opened this issue Apr 18, 2024 · 2 comments · Fixed by #100

Comments

@KristofferC
Copy link
Member

Don't know what this is trying to test exactly:

@test read(compat_file, String) == """
[1]
julia = "1.3.0-1"
"""

Right now it gets

compat_file: Test Failed at /home/pkgeval/.julia/packages/RegistryTools/2CM18/test/regedit.jl:333
  Expression: read(compat_file, String) == "[1]\njulia = \"1.3.0-1\"\n"
   Evaluated: "[1]\njulia = \"1.3.0 - 1\"\n" == "[1]\njulia = \"1.3.0-1\"\n"
``
@GunnarFarneback
Copy link
Collaborator

I do https://github.com/GunnarFarneback/LocalRegistry.jl/blob/master/test/utils.jl#L114-L122 in the LocalRegistry tests but I'm curious why this formatting changed, so I can update the comment in that excerpt.

@DilumAluthge
Copy link
Member

Introduced in JuliaLang/Pkg.jl#3580 I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants