-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add commit hash information to registry #97
Open
simonbyrne
wants to merge
5
commits into
JuliaRegistries:master
Choose a base branch
from
simonbyrne:sb/commit-hash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9096e44
to
ed1d1f6
Compare
ed1d1f6
to
0ceb204
Compare
b7e68b7
to
9415286
Compare
simonbyrne
commented
Dec 31, 2023
Instead of sticking everything at the same level as versions = Dict()
versions["1.2.3"] = Dict(
"git-tree-sha1" => "...",
"optional" => Dict(
"git-commit-sha1" => "...",
"some-other-info" => "helloworld",
),
) |
that seems more complicated? |
3f6a5b9
to
0329c2d
Compare
I decided against including |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of JuliaLang/Pkg.jl#3718.
This adds 4 optional keys to each version:
git-commit-sha1
: the hash of a git commit object corresponding to the release. This is required if any of the other keys exist.git-tag-name
: the name of the git tagsubdir
: the subdirectory of the tree with respect to the root of the repository.These should satisfy the following:
subdir
of the commitgit-commit-sha1
should begit-tree-sha1
. In other words,git rev-parse $(git-commit-sha1):$(subdir) == $(git-tree-sha1)
. Ifsubdir
is not defined, then it should be the root tree.git-tag-name
should resolve to the commitgit-commit-sha1
. That is,git rev-parse $(git-tag-name)^{commit} == $(git-commit-sha1)
Unlike
git-tree-sha1
, these keys should all be considered potentially mutable (i.e. the repository may be modified so that the values of these keys may change).cc @IanButterworth