Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly failures of usage of with #96

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

jaakkor2
Copy link
Contributor

PR #95 showed

WARNING: both LibGit2 and Base export "with"; uses of it in module Main must be qualified

@jaakkor2
Copy link
Contributor Author

Now nightly fails with

compat_file: Test Failed at D:\a\RegistryTools.jl\RegistryTools.jl\test\regedit.jl:333
Expression: read(compat_file, String) == "[1]\njulia = "1.3.0-1"\n"
Evaluated: "[1]\njulia = "1.3.0 - 1"\n" == "[1]\njulia = "1.3.0-1"\n"

i.e., string formatting has added space characters

@GunnarFarneback
Copy link
Collaborator

This looks like a strict improvement regardless of nightly failures.

@GunnarFarneback GunnarFarneback merged commit 8418a12 into JuliaRegistries:master Jun 9, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants