Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bump compat for equality specifiers #444

Closed
mortenpi opened this issue Dec 21, 2022 · 2 comments
Closed

Don't bump compat for equality specifiers #444

mortenpi opened this issue Dec 21, 2022 · 2 comments

Comments

@mortenpi
Copy link

If you have e.g. Foo = "=1.2.3, CompatHelper will suggest Foo = "=1.2.3, 1 when e.g. 1.3 comes along. I don't think it should, since if you are using an equality specifier, you probably have a good reason not to allow newer versions.

Maybe tangentially related to #266?

@Octogonapus
Copy link
Contributor

I think this is a duplicate of #250, which was fixed in #251, so this should be closed.

@mortenpi
Copy link
Author

mortenpi commented Feb 7, 2023

Oh, you need to set an argument to disable this. I never checked the main() docstring.

Then I would suggest making bump_compat_containing_equality_specifier=false the default, rather than true, although I know that would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants