Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check docs/Project.toml and test/Project.toml as well #454

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lgoettgens
Copy link
Contributor

Resolves #408.

I made some decisions while adding this, that could be converted into config settings at a later point, if so desired:

  1. Do not create new compat entries here, only update existing ones. Many projects duplicate some of their deps as test-deps as well, but do not want to keep track of both compats, as the test-dep compat is clear due to transitivity anyway.
  2. Updating a compat entry here does never do a version bump in the main Project.toml. But I think this is fine as one does not need to release a change to test-deps or docs-deps anyway.

Unfortunately, I do not see myself being able to write tests for this. I am just lost in the mocking and patching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does CompatHelper send PRs to update project.toml files in subdirectories?
1 participant