From 8f823f96506defcc55bd1bc223fa7eb95a517371 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Tue, 9 Jul 2019 17:03:16 +0200 Subject: [PATCH 1/3] remove comments from script --- build_tarballs.jl | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/build_tarballs.jl b/build_tarballs.jl index 1db3ebe..a15ec9d 100644 --- a/build_tarballs.jl +++ b/build_tarballs.jl @@ -12,22 +12,11 @@ sources = [ ] -# Adapted from builder by kalmarek (https://github.com/JuliaPackaging/BinaryBuilder.jl/issues/313) # Bash recipe for building across all platforms script = raw""" cd $WORKSPACE/srcdir cd scs-2.0.2/ -# Mac OS and Windows do not have openmp by default -#if [ $target = "x86_64-apple-darwin14" ] || [ $target = "x86_64-w64-mingw32" ] || [ $target = "i686-w64-mingw32" ]; then -# flags="DLONG=1" -#else -# flags="DLONG=1 USE_OPENMP=1" -#fi -# GOMP 4.0 would be required for OPENMP, which makes travis fail because it only has gcc version 4.8.4 flags="DLONG=1 USE_OPENMP=0" -#if [ $target = "x86_64-apple-darwin14" ]; then -# install_name_tool -id libopenblas64_.dylib ${prefix}/lib/libopenblas64_.0.3.0.dev.dylib -#fi blasldflags="-L${prefix}/lib" if [[ ${nbits} == 32 ]]; then blasldflags="${blasldflags} -lopenblas"; else flags="${flags} BLAS64=1 BLASSUFFIX=_64_"; blasldflags="${blasldflags} -lopenblas64_"; fi make BLASLDFLAGS="${blasldflags}" ${flags} out/libscsdir.${dlext} From 274a12458050caeb283a2685e565f90d392a5de8 Mon Sep 17 00:00:00 2001 From: kalmarek Date: Tue, 9 Jul 2019 17:01:05 +0200 Subject: [PATCH 2/3] update to scs-v2.1.1 and openblas-v0.3.5-2 --- build_tarballs.jl | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/build_tarballs.jl b/build_tarballs.jl index a15ec9d..c446e8e 100644 --- a/build_tarballs.jl +++ b/build_tarballs.jl @@ -3,19 +3,18 @@ using BinaryBuilder name = "SCSBuilder" -version = v"2.0.2" +version = v"2.1.1" # Collection of sources required to build SCSBuilder sources = [ - "https://github.com/cvxgrp/scs/archive/v2.0.2.tar.gz" => - "8725291dfe952a1f117f1f725906843db392fe8d29eebd8feb14b49f25fc669e", + "https://github.com/cvxgrp/scs/archive/$(version).tar.gz" => + "0e20b91e8caf744b84aa985ba4e98cc7235ee33612b2bad2bf31ea5ad4e07d93", ] # Bash recipe for building across all platforms script = raw""" -cd $WORKSPACE/srcdir -cd scs-2.0.2/ +cd $WORKSPACE/srcdir/scs-* flags="DLONG=1 USE_OPENMP=0" blasldflags="-L${prefix}/lib" if [[ ${nbits} == 32 ]]; then blasldflags="${blasldflags} -lopenblas"; else flags="${flags} BLAS64=1 BLASSUFFIX=_64_"; blasldflags="${blasldflags} -lopenblas64_"; fi @@ -29,8 +28,8 @@ mv out/libscs* ${prefix}/lib/ # Eventually, this should be fixed upstream if [[ ${target} == "x86_64-apple-darwin14" ]]; then echo "-- Modifying library name for OpenBLAS" - install_name_tool -change libopenblas64_.0.3.0.dev.dylib libopenblas64_.dylib ${prefix}/lib/libscsindir.dylib - install_name_tool -change libopenblas64_.0.3.0.dev.dylib libopenblas64_.dylib ${prefix}/lib/libscsdir.dylib + install_name_tool -change libopenblas64_.0.3.5.dev.dylib libopenblas64_.dylib ${prefix}/lib/libscsindir.dylib + install_name_tool -change libopenblas64_.0.3.5.dev.dylib libopenblas64_.dylib ${prefix}/lib/libscsdir.dylib fi """ @@ -61,7 +60,7 @@ products(prefix) = [ # Dependencies that must be installed before this package can be built dependencies = [ - "https://github.com/JuliaLinearAlgebra/OpenBLASBuilder/releases/download/v0.3.0-3/build_OpenBLAS.v0.3.0.jl" + "https://github.com/JuliaPackaging/Yggdrasil/releases/download/OpenBLAS-v0.3.5-2/build_OpenBLAS.v0.3.5.jl" ] # Build the tarballs, and possibly a `build.jl` as well. From a51d810af067602f4136d02a9cca9b244781d66a Mon Sep 17 00:00:00 2001 From: kalmarek Date: Thu, 11 Jul 2019 13:57:32 +0200 Subject: [PATCH 3/3] update openblas suffix for aarch64 --- build_tarballs.jl | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/build_tarballs.jl b/build_tarballs.jl index c446e8e..d778efb 100644 --- a/build_tarballs.jl +++ b/build_tarballs.jl @@ -12,12 +12,18 @@ sources = [ ] -# Bash recipe for building across all platforms +# Bash recipe for building across all platforms script = raw""" cd $WORKSPACE/srcdir/scs-* flags="DLONG=1 USE_OPENMP=0" blasldflags="-L${prefix}/lib" -if [[ ${nbits} == 32 ]]; then blasldflags="${blasldflags} -lopenblas"; else flags="${flags} BLAS64=1 BLASSUFFIX=_64_"; blasldflags="${blasldflags} -lopenblas64_"; fi +# see https://github.com/JuliaPackaging/Yggdrasil/blob/0bc1abd56fa176e3d2cc2e48e7bf85a26c948c40/OpenBLAS/build_tarballs.jl#L23 +if [[ ${nbits} == 64 ]] && [[ ${target} != aarch64* ]]; then + flags="${flags} BLAS64=1 BLASSUFFIX=_64_" + blasldflags+=" -lopenblas64_" +else + blasldflags+=" -lopenblas" +fi make BLASLDFLAGS="${blasldflags}" ${flags} out/libscsdir.${dlext} make BLASLDFLAGS="${blasldflags}" ${flags} out/libscsindir.${dlext} mv out/libscs* ${prefix}/lib/ @@ -65,4 +71,3 @@ dependencies = [ # Build the tarballs, and possibly a `build.jl` as well. build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies) -