Switch from Zygote to Enzyme #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 72.69% 74.05% +1.36%
==========================================
Files 37 36 -1
Lines 5560 4942 -618
==========================================
- Hits 4042 3660 -382
+ Misses 1518 1282 -236 ☔ View full report in Codecov by Sentry. |
|
@jgreener64 if any of these issues are still outstanding, I can try to quickly fix if you have MWE's |
Member
Author
|
Thanks for asking. It's mostly the GPU reduction stuff (JuliaGPU/CUDA.jl#2471) and any further issues that uncovers. Also EnzymeAD/Enzyme.jl#1672 would be useful but is not blocking. |
Member
Author
|
Merging this to prevent development stalling elsewhere. There are a few things that need fixing before release related to Enzyme, GPU support and docs updates. |
ToucheSir
added a commit
to FluxML/ZygoteRules.jl
that referenced
this pull request
Jan 21, 2025
Molly.jl no longer uses Zygote: JuliaMolSim/Molly.jl#182. Are there any other packages here which should go? The fewer we have to deal with, the faster CI runs and the fewer false positives we get from it.
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching from using Zygote+Enzyme to just using Enzyme for AD allows us to rewrite much of the main computation code to mutate memory. This improves performance on CPU and GPU.
Opening this PR to test with CI.