Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HierarchicalMatrices should use BlockArrays #4

Open
dlfivefifty opened this issue Nov 5, 2017 · 2 comments
Open

HierarchicalMatrices should use BlockArrays #4

dlfivefifty opened this issue Nov 5, 2017 · 2 comments

Comments

@dlfivefifty
Copy link
Member

BlockArrays has a well-developed block matrix structure, so this would avoid needing your own Block.

@MikaelSlevinsky
Copy link
Member

You're talking mainly about the abstract block array interface, and not the concrete block array type, right? AFAICT, hierarchical matrices are block arrays where the blocks are different types, but this is staged for performance. On the other hand, the concrete block array type has templated the block type. I don't see how a getindex on the blocks would ever be performant for hierarchical matrices due to the type instability. setindex!, though is type stable.

@dlfivefifty
Copy link
Member Author

dlfivefifty commented Nov 5, 2017

I meant HierarchicalMatrix{T} <: AbstractBlockMatrix{T}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants