Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pkg.precompile within test sandbox prints without color #4158

Open
IanButterworth opened this issue Feb 15, 2025 · 2 comments
Open

Pkg.precompile within test sandbox prints without color #4158

IanButterworth opened this issue Feb 15, 2025 · 2 comments

Comments

@IanButterworth
Copy link
Member

I couldn't see why on a quick look

Image
@IanButterworth
Copy link
Member Author

I've tried to understand this but the io types passed around in Pkg and how color is determined on them in Base is pretty complicated. @KristofferC does the reason jump out to you? Note that apart from the main Pkg.test precompile, the only ones that show up without color in Pkg tests are the apps tests, which don't specify the io specifically.

@giordano
Copy link
Contributor

Just to add a datapoint, this is running Pkg.instantiate in v1.10 (top) vs v1.11 (bottom) in GitHub Actions:

Image

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giordano @IanButterworth