Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print diff when a tracked branch changes #274

Open
fredrikekre opened this issue May 3, 2018 · 1 comment
Open

Print diff when a tracked branch changes #274

fredrikekre opened this issue May 3, 2018 · 1 comment

Comments

@fredrikekre
Copy link
Member

I think it would be useful to print a diff when a tracked branch is updated. Current behaviour:

pkg> add BenchmarkTools#master

# change the master branch

pkg> up
[...]
  Updating `~/.julia/environments/v0.7/Project.toml`
 [6e4b80f9] ~ BenchmarkTools v0.2.5+ #master
  Updating `~/.julia/environments/v0.7/Manifest.toml`
 [6e4b80f9] ~  BenchmarkTools v0.2.5+ #master

which IMO would be better as

pkg> up
[...]
  Updating `~/.julia/environments/v0.7/Project.toml`
 [6e4b80f9] ↑ BenchmarkTools v0.2.5+ #master(commit1) ⇒ v0.2.5+ #master(commit2)
  Updating `~/.julia/environments/v0.7/Manifest.toml`
 [6e4b80f9] ↑ BenchmarkTools v0.2.5+ #master(commit1) ⇒ v0.2.5+ #master(commit2)

Additionally, perhaps we should always print the commit hash for tracked branches, e.g. st would change from

(v0.7) pkg> st
Status `~/.julia/environments/v0.7/Project.toml`
 [6e4b80f9] BenchmarkTools v0.2.5+ #master

to

(v0.7) pkg> st
Status `~/.julia/environments/v0.7/Project.toml`
 [6e4b80f9] BenchmarkTools v0.2.5+ #master(commit)
@KristofferC
Copy link
Member

We actually don't store the commit SHA (only the tree sha) for tracked branches. We could though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants