From c2c99807b157d6b9e23d09fa597800ec0e715cee Mon Sep 17 00:00:00 2001 From: Kristoffer Carlsson Date: Tue, 15 Sep 2020 10:15:50 -0700 Subject: [PATCH] remove the env var for setting download concurrency (#2020) --- src/Types.jl | 4 +--- test/new.jl | 9 --------- test/pkg.jl | 7 ------- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/src/Types.jl b/src/Types.jl index cf4df1f710..0409419473 100644 --- a/src/Types.jl +++ b/src/Types.jl @@ -326,9 +326,7 @@ Base.@kwdef mutable struct Context io::IO = something(DEFAULT_IO[], stderr) use_libgit2_for_all_downloads::Bool = false use_only_tarballs_for_downloads::Bool = false - # NOTE: The JULIA_PKG_CONCURRENCY environment variable is likely to be removed in - # the future. It currently stands as an unofficial workaround for issue #795. - num_concurrent_downloads::Int = haskey(ENV, "JULIA_PKG_CONCURRENCY") ? parse(Int, ENV["JULIA_PKG_CONCURRENCY"]) : 8 + num_concurrent_downloads::Int = 8 graph_verbose::Bool = false currently_running_target::Bool = false # test instrumenting diff --git a/test/new.jl b/test/new.jl index 966a0e73d9..fb5d887a15 100644 --- a/test/new.jl +++ b/test/new.jl @@ -2248,15 +2248,6 @@ end end end -@testset "Set download concurrency" begin - isolate() do - withenv("JULIA_PKG_CONCURRENCY" => 1) do - ctx = Pkg.Types.Context() - @test ctx.num_concurrent_downloads == 1 - end - end -end - @testset "API details" begin # API should not mutate isolate() do diff --git a/test/pkg.jl b/test/pkg.jl index 1f0ec28608..62512be3ab 100644 --- a/test/pkg.jl +++ b/test/pkg.jl @@ -526,13 +526,6 @@ end end @test Pkg.Types.pathrepr(path) == "`@stdlib/Test`" end -@testset "Set download concurrency" begin - withenv("JULIA_PKG_CONCURRENCY" => 1) do - ctx = Pkg.Types.Context() - @test ctx.num_concurrent_downloads == 1 - end -end - @testset "stdlib_resolve!" begin a = Pkg.Types.PackageSpec(name="Markdown") b = Pkg.Types.PackageSpec(uuid=UUID("9abbd945-dff8-562f-b5e8-e1ebf5ef1b79"))