Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and complete equality definitions #337

Open
devmotion opened this issue Jul 9, 2021 · 0 comments
Open

Fix and complete equality definitions #337

devmotion opened this issue Jul 9, 2021 · 0 comments

Comments

@devmotion
Copy link
Member

If one defines isequal one has to define hash as well since otherwise the two are not consistent. In general, if one does not care about floating point comparisons one should just define == instead of isequal since isequal falls back to ==. Here it probably would make sense to define both since it would lead to different comparisons of the kernel parameters and parameters of the transform.

Basically, most often one wants the recursive implementation in JuliaServices/AutoHashEquals.jl#18.

Originally posted by @devmotion in #335 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant