New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laplace objective.f #62

Open

willtebbutt opened this issue Sep 29, 2021 · 1 comment

Member

willtebbutt commented Sep 29, 2021 •

edited by st--

Loading

Having slept on this, I'm still not completely comfortable with suggesting that the official way to get f is via the objective because there seem to be details that change depending upon where it's defined.

Maybe it would make sense to add a struct which explicitly contains f, and whose evaluation is defined to compute the objective? i.e. formalise the API.

Yeah I was wondering something similar. would you be up for proposing a way of doing that in a separate PR?

Originally posted by @st-- in #59 (comment)

willtebbutt mentioned this issue

add Laplace approximation #59

Merged

Member

st-- commented Mar 21, 2022

I just realised I could've resolved this with #109 in one go 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment