Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convergence output can have 0 or even negative values #127

Open
Datseris opened this issue Jun 6, 2024 · 0 comments
Open

convergence output can have 0 or even negative values #127

Datseris opened this issue Jun 6, 2024 · 0 comments
Assignees
Labels
accuracy Accuracy of results bug Something isn't working mapper related with `AttractorMapper`

Comments

@Datseris
Copy link
Member

Datseris commented Jun 6, 2024

After my updates to the convergence output in

fractions, labels, convergence = convergence_and_basins_fractions(mapper, ics; show_progress = false)

I've noticed that simulation results can have 0 or even negative convergence for the recurrences mapper.

Clearly, this is because of errors in the new logic I've implemented that adjusts convergence counts given the state of the finite state machine. I need to fix this, and I need to implement a robust test case for it as well to ensure it is working properly...

@Datseris Datseris added bug Something isn't working mapper related with `AttractorMapper` accuracy Accuracy of results labels Jun 6, 2024
@Datseris Datseris self-assigned this Jun 6, 2024
@Datseris Datseris changed the title convergence output can have real or even negative values convergence output can have 0 or even negative values Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accuracy Accuracy of results bug Something isn't working mapper related with `AttractorMapper`
Projects
None yet
Development

No branches or pull requests

1 participant