Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwargs not passed to subset in @subset with multiple conditions #399

Open
FuZhiyu opened this issue Jun 26, 2024 · 1 comment · May be fixed by #400
Open

kwargs not passed to subset in @subset with multiple conditions #399

FuZhiyu opened this issue Jun 26, 2024 · 1 comment · May be fixed by #400

Comments

@FuZhiyu
Copy link
Contributor

FuZhiyu commented Jun 26, 2024

See the example below:

df = DataFrame(a = [1, 2, missing], b = [4, 5, 6])
@subset(df, :a .== 1; view = true)
# return a SubDataFrame

@subset(df, :a .== 1; skipmissing = false)
# throw an error as there is a missing value in the condition

@subset(df, :a.== 1, :b .== 4; view = true)
# return a DataFrame rather than a SubDataFrame!!!

@subset(df, :a.== 1, :b .== 4; skipmissing = false)
# return a DataFrame! No error was thrown.

Version info: Julia 1.10

[a93c6f00] DataFrames v1.6.1
[1313f7d8] DataFramesMeta v0.15.2

@pdeffebach
Copy link
Collaborator

Thank you. I can replicate this and am working on a fix. This is a serious issue and I will get a fix together soon. I apologize for this bug.

@pdeffebach pdeffebach linked a pull request Jun 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants