-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What do you think about @groupby ? #302
Comments
Thanks for filing the issue! I don't think it's worth adding a macro just for the sake of consistency with This was actually a major benefit of the now-deprecated DataFrameMacros.jl has a I want to emulate this behavior but I want to call it something different. One alternative would be to have a |
Thx for the quick reply and the consideration. I am coming from rstats tidyverse where it seems everything is conceptually so much easier to accomplish than their counterparts in Julia; the Julia syntax and typing is a lot of mental overhead. Your package is an exception though - it is exceptionally easy to use! Thank you! For example, the @rfoo macros are just a tremendous addition to easy-to-code data manipulation pipelines. Anyway, anything leading to easy-to-rememberness is very welcomed by me and this pattern-breaking by I hope some community members might chime in and agree, but either way thx for the great package. |
I would have no problem with adding |
I agree that it could make sense to add the macro just for consistency, even if it's identical to the function. |
Sounds good. I can start a PR adding this. |
Great! Please know that I am not clear on the "transforms" issue above, so can't comment on that. That being said, identical functionality to |
You might want to groupby not by columns directly but by their transformations (e.g. you have a columns of integers and you want to groupby the fact if the value is even or odd) |
I had a good idea this week for more features, something like
where the operations inside the This is partly a hack because we still don't have a syntax for keyword arguments, so you can't have I don't think this means we can't introduce a |
I am a big fan of Hadley Wickham's pit of success where it is easy to remember how to do things. I find the fact that groupby is the only non-macro getting used in a typical DataFramesMeta workflow creates mental friction for new users (and me). Wouldn't it be nice if the below table could have the @ symbol in front of group by? Can an alias be made?
![image](https://user-images.githubusercontent.com/17184441/135133349-5515e9f3-75c2-44db-bd39-8d630d109c12.png)
The text was updated successfully, but these errors were encountered: