Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrow and ncol for DataFrameRows and DataFrameColumns #3054

Closed
bkamins opened this issue May 20, 2022 · 4 comments · Fixed by #3311
Closed

nrow and ncol for DataFrameRows and DataFrameColumns #3054

bkamins opened this issue May 20, 2022 · 4 comments · Fixed by #3311
Labels
question
Milestone
1.6

Comments

@bkamins
Copy link
Member

bkamins commented May 20, 2022

@nalimilan:
Do we want DataFrameRows and DataFrameColumns to be considered to be Tables.jl tables and eg. define for them nrow and ncol?
@bkamins bkamins added this to the 1.4 milestone May 20, 2022
@nalimilan
Copy link
Member

What's the context of this? I don't see a strong reason not to do this but better have use cases before adding features?

@bkamins
Copy link
Member Author

bkamins commented May 20, 2022

The context is JuliaData/Tables.jl#278 (comment). If we decide to add nrow and ncol support for Tables.jl tables in general and decide to treat these two types as tables (apart of treating AbstractDataFrame as table) then we should add this support.

@nalimilan
Copy link
Member

OK. Let's wait until a decision is made in Tables.jl first?

@bkamins
Copy link
Member Author

bkamins commented May 23, 2022

Yes, I just want to track this here.

@bkamins bkamins modified the milestones: 1.4, 1.5 Jun 7, 2022
@bkamins bkamins mentioned this issue Jun 10, 2022
Closed
@bkamins bkamins modified the milestones: 1.5, 1.6 Feb 5, 2023
@bkamins bkamins mentioned this issue Mar 12, 2023
Merged
This was referenced Apr 4, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
1.6
Development

Successfully merging a pull request may close this issue.

add nrow, ncol, and Tables.subset for eachcol and eachrow JuliaData/DataFrames.jl
2 participants
@nalimilan @bkamins