Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runbenchmarks(predicate) on a PR fails to infer comparison build #149

Open
LilithHafner opened this issue Dec 27, 2022 · 1 comment
Open

runbenchmarks(predicate) on a PR fails to infer comparison build #149

LilithHafner opened this issue Dec 27, 2022 · 1 comment

Comments

@LilithHafner
Copy link
Contributor

Commenting this on a PR (example)

@nanosoldier `runbechmarks("sort")`

results in a benchmark job without any comparison.

In contrast, it is documented to automatically infer the comparison branch:

The vs keyword argument is optional; if invoked from a pull request, it will be derived automatically from the merge base. In other cases, the comparison step (step 3 above) will be skipped.
@LilithHafner LilithHafner changed the title runbenchmarks(predicate) on a PR fails to infer comparison build runbenchmarks(predicate) on a PR fails to infer comparison build Dec 27, 2022
@maleadt
Copy link
Member

maleadt commented Dec 28, 2022

That's because @vtjnash hasn't updated the benchmark bot to the latest Nanosoldier.jl yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maleadt @LilithHafner