feat: 🎸 Only run ubuntu with Julia 1 on PRs #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsiqueira
force-pushed
the
105-conditional-build
branch
from
c27cbd4
to
53e0dd2
Compare
Using the workflow matrix and conditions to include and exclude, we only run the full matrix on pushes. For PRs, only 1 build is made, using ubuntu and Julia 1. Also adds a question TestPRsOnlyOneMachine to include the same in the template. Default to true. ✅ Closes: #105
abelsiqueira
force-pushed
the
105-conditional-build
branch
from
53e0dd2
to
54872d3
Compare
|
@suvayu, this is your kind of PR. If you have the time, can you review this? |
suvayu
approved these changes
Jun 1, 2024
Remove the other PR testing strategy and add reusable workflows to implement simpler PR testing. Also renames the question key to better address the objective. Adds informtaion on the Explanation section about these changes. ✅ Closes: #105
suvayu
approved these changes
Jun 2, 2024
Co-authored-by: Suvayu Ali <[email protected]>
|
@suvayu, thanks for the review. It looks pretty good right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the workflow matrix and conditions to include and exclude, we only
run the full matrix on pushes. For PRs, only 1 build is made, using
ubuntu and Julia 1.
Also adds a question TestPRsOnlyOneMachine to include the same in the template. Defaults to true.
✅ Closes: #105