Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of coerce! DataFrames hack #192

Open
ablaom opened this issue May 7, 2023 · 0 comments
Open

Get rid of coerce! DataFrames hack #192

ablaom opened this issue May 7, 2023 · 0 comments

Comments

@ablaom
Copy link
Member

ablaom commented May 7, 2023

At the moment coerce! is a variation of coerce that works in-place for data frames. But to avoid adding DataFrames as a dependency, there is a hack:

ScientificTypes.jl/src/coerce.jl

Line 197 in 10b3323

if is_type(X, :DataFrames, :DataFrame)

Now we have optional dependencies this hack can be removed.
@github-project-automation github-project-automation bot moved this to priority low / straightforward in General Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
General
Status: priority low / straightforward
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ablaom