Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support MLJ training per data sample weight #56

Merged
merged 4 commits into from
Nov 30, 2024
Merged

support MLJ training per data sample weight #56

merged 4 commits into from
Nov 30, 2024

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Nov 27, 2024

fix #55

@Moelf Moelf mentioned this pull request Nov 27, 2024
Closed
@ablaom
Copy link
Member

ablaom commented Nov 28, 2024

Looks good to me, thank you.

Could we at least have a smoke test verifying addition of weights makes a difference?

@Moelf
Copy link
Contributor Author

Moelf commented Nov 28, 2024

done!

ablaom
ablaom approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Moelf for you valuable contribution 🙏🏾

@Moelf
Copy link
Contributor Author

Moelf commented Nov 29, 2024

let's try the CI again

@ablaom ablaom merged commit b1f5c91 into JuliaAI:master Nov 30, 2024
2 checks passed
This was referenced Nov 30, 2024
Merged
Closed
@Moelf Moelf deleted the support_weight branch December 1, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom ablaom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing access weight= in DMatrix for sample weight
2 participants
@Moelf @ablaom