Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update model registry #544

Closed
1 task done
ablaom opened this issue Jan 15, 2024 · 2 comments · Fixed by #545
Closed
1 task done

Update model registry #544

ablaom opened this issue Jan 15, 2024 · 2 comments · Fixed by #545

Comments

@ablaom
Copy link
Member

ablaom commented Jan 15, 2024

Waiting for:

  • Imbabance 0.1.5
  • [ ] BetaML 0.10.5 or 0.11

which have changed model metadata.

cc @EssamWisam @sylvaticus

@sylvaticus
Copy link

I would like to change the other model interface too, including for some their names, in order to make the interface homogeneous under the common submodule 'Bmlj'.. is it now the right moment?

@ablaom
Copy link
Member Author

ablaom commented Jan 15, 2024

I would like to change the other model interface too, including for some their names, in order to make the interface homogeneous under the common submodule 'Bmlj'.. is it now the right moment?

I think that when a model name changes, that's definitely breaking. So to minimise breaking changes in BetaML, it might be a good idea to tend to those before the next release. In that case I'll just proceed with a new model registry update soon and we can do another when you're ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants