New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A column with `missing` as first value trips `OneHotEncoder` #467

Closed

ablaom opened this issue Aug 1, 2022 · 0 comments · Fixed by #468

Member

ablaom commented Aug 1, 2022

using MLJModels, CategoricalArrays, MLJBase
X = (x=categorical([missing, 1, 2, 1])
t  = OneHotEncoder(drop_last = true)
f, _, report = MLJBase.fit(t, 1, X)

Re-posted from #458 (comment), which diagnoses the issue and suggests a fix.

ablaom mentioned this issue

Enhance treatment of missing value in one-hot encoder #458

Open

olivierlabayle mentioned this issue

fix one hot encoder when first value in column is missing #468

Merged

ablaom closed this as completed in #468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment