Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement measures checks #20

Closed
OkonSamuel opened this issue Jun 6, 2022 · 1 comment
Closed

Implement measures checks #20

OkonSamuel opened this issue Jun 6, 2022 · 1 comment

Comments

@OkonSamuel
Copy link
Member

OkonSamuel commented Jun 6, 2022

We need to Implement measures checks for measures passed to out_of_bag_measure parameter of EnsembleModel.
Currently any Vector of Julia objects can be passed as input to the out_of_bag_measure parameter of EnsembleModel, whereas this should only allow passing a vector of MLJ measures.
Also, the current implementation allows observation weights to be passed to any measure, even those measures supporting only class-weights. Hence checks should be implemented to avoid this and throw an informative error message.
Finally, users can even pass measures that are only valid for classifiers to DeterministicEnsembleModels making deterministic predictions. Check have to be implemented to avoid this also.

These checks could be similar to the one found here

@ablaom
Copy link
Member

ablaom commented Mar 9, 2023

Closing in favour of #26.

@ablaom ablaom closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants