Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of TableOperations.jl for column access #790

Open
OkonSamuel opened this issue Jun 14, 2022 · 3 comments
Open

Possibility of TableOperations.jl for column access #790

OkonSamuel opened this issue Jun 14, 2022 · 3 comments
Projects

Comments

@OkonSamuel
Copy link
Member

We should be able to apply methods from TableOperations.jl to reimplement the selectrows and selectcols method for generic tables. This should help us avoid the issue we are currently experiencing with materializing NamedTuples

@ablaom
Copy link
Member

ablaom commented Jun 16, 2022

For selecting rows, I'm hoping JuliaData/Tables.jl#278 will be more helpful, as it allows individual Tables formats to expose more efficient selection methods to the generic Tables.jl API, which TableOperations.jl cannot do. And one idea, is to subsume table-row access under the more generic getobs API at MLUtils.jl.

But happy to go with your suggestion for TableOperations.jl for column access.

@ablaom ablaom changed the title Possibility of TableOperations.jl in MLJBase Possibility of TableOperations.jl for column access Jun 16, 2022
@ablaom
Copy link
Member

ablaom commented Jun 16, 2022

Worth noting here that, as far as I know, selectcols is not used within MLJBase at all, only selectrows. However, I believe it is exposed in MLJModelInterface, and the transformers in MLJModels do use it. I'd be inclined to removing this from MLJModelInterface in the future. A model provider really wanting generic table column accesss could just import Tables.jl or TableOperations.jl, I guess.

@ablaom ablaom added this to priority low / involved in General Jun 16, 2022
@juliohm
Copy link
Contributor

juliohm commented Apr 18, 2023

TableTransforms.jl has many operations for selecting, filtering, ... generic Tables.jl tables. It is very aligned with ML pipelines and I would consider using it instead of TableOperations.jl, which got stuck in time and is very limited in terms of functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
General
priority low / involved
Development

No branches or pull requests

3 participants