Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emigration of one-dimensional range types #572

Open
ablaom opened this issue Jun 7, 2021 · 1 comment
Open

Emigration of one-dimensional range types #572

ablaom opened this issue Jun 7, 2021 · 1 comment

Comments

@ablaom
Copy link
Member

ablaom commented Jun 7, 2021

Currently there is the possibility of declaring default ranges for model hyper-parameters, for use one day in hyper-parameter optimization. However, the one-parameter range objects NominalRange and NumericRange, and their constructors, are defined in MLJBase and not MLJModelInterface. Since the idea is that implementing the MLJ model API should not require having MLJBase as a dependency, we should:

  1. Migrate the types/constructors to MLJModelInterface; or
  2. Move both types/constructors and methods (iterator, sampler, and so forth) to a stand-alone package for possible use outside MLJ.

Thoughts anyone?

@ablaom ablaom changed the title Migrate one-dimensional range types and constructors to MLJModelInterface Emigration of one-dimensional range types Jun 7, 2021
@ablaom
Copy link
Member Author

ablaom commented Sep 22, 2021

Comment to self:

At present the first argument can have type Model for automatic inference of the type of the hyper-parameter. But the method is now also overloaded to accept the type itself. So, in the port, we do the latter and leave the former overloading for MLJBase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant