Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MLJ Serialization, add test for single class classifiers, fix single class classifiers predict #35

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

tylerjthomas9
Copy link
Collaborator

Ref #34

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 71.14%. Comparing base (28930d4) to head (e026b62).
Report is 1 commits behind head on main.

Files Patch % Lines
src/mlj_serialization.jl 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   75.55%   71.14%   -4.42%     
==========================================
  Files           6        6              
  Lines         180      201      +21     
==========================================
+ Hits          136      143       +7     
- Misses         44       58      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ablaom ablaom merged commit 13b1919 into JuliaAI:main Jun 18, 2024
7 of 10 checks passed
@tylerjthomas9 tylerjthomas9 deleted the mlj-serialization branch December 15, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants