Skip to content

Commit

Permalink
Cleanup some MathML tests using unshipped features.
Browse files Browse the repository at this point in the history
* dir-1: Ignore mfenced (no longer implemented) and move the remaining
  case not tested by direction-overall.html into direction-mpadded.html
  This seems complementary to the RTL test in mpadded-003.html

* link-1: We removed support for XLink in MathML. This is actually
  testing non-XLink href, removed unnecessary XLink stuff.

* mstyle-1: We removed support for all these attributes except
  linethickness, already covered by legacy-mstyle-attributes.html

* mstyle-2: We removed support for maction.

* mstyle-3: We removed support for nonzero unitless values, use
  equivalent length expression.

* mstyle-5: We removed support for lquote/rquote.

* table-width-1: Remove test for mfenced (no longer implemented).

* semantics-1: We removed support for maction.

* ssty3/ssty4: These tests were removed in bug 1788637 but the
  references were incorrectly left.

* opentype-stretchy.html: Was likely using scriptminsizemultiplier="1"
  to make the test more robust, but unshipping support for this
  attribute didn't affect the test.

* mathml_example_test.html: Ditto.

* mfrac-D-2.html: We removed support for linethickness="thin", use
  another valid value different to the one set by JS.

* number-size: We removed support for non-zero unitless values.
  Already covered by mathml/relations/css-styling/lengths-1.html

* mfrac-linethickness{1,2,3}: We removed support for
  non-zero unitless values. Move uncovered tests into
  presentation-markup/fractions/frac-linethickness-001.html
  frac-linethickness-002.html also checks negative values,
  but Firefox does not align with MathML Core (bug 1846718).

* munderover-align-accent-false.html: We removed support for
  munderover@align. This was using the default "center" value
  and had no effect.

* scriptshift-1: We removed support for subscriptshift and
  superscriptshift. Already covered by
  subsup-legacy-scriptshift-attributes-001.tentative.html

Differential Revision: https://phabricator.services.mozilla.com/D185146

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1846721
gecko-commit: ca0ed80a18d3ecf723d93683a8c2938fb36e8ab4
gecko-reviewers: emilio
  • Loading branch information
fred-wang authored and moz-wptsync-bot committed Aug 3, 2023
1 parent b9998d2 commit ecd28aa
Show file tree
Hide file tree
Showing 4 changed files with 92 additions and 2 deletions.
21 changes: 21 additions & 0 deletions mathml/presentation-markup/direction/direction-mpadded-ref.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8"/>
<title>Verify dir attribute on mpadded (reference)</title>
</head>
<body>
<p>
mpadded lspace="25px" width="150px":
<math>
<mspace width="1px" height="25px" mathbackground="black"/>
<mpadded lspace="50px" width="150px">
<mspace width="25px" height="25px" mathbackground="blue"/>
<mspace width="25px" height="25px" mathbackground="green"/>
<mspace width="25px" height="25px" mathbackground="red"/>
</mpadded>
<mspace width="1px" height="25px" mathbackground="black"/>
</math>
</p>
</body>
</html>
29 changes: 29 additions & 0 deletions mathml/presentation-markup/direction/direction-mpadded.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8"/>
<title>Verify dir attribute on mpadded</title>
<link rel="help" href="https://w3c.github.io/mathml-core/#attributes-common-to-html-and-mathml-elements">
<link rel="help" href="https://w3c.github.io/mathml-core/#css-styling">
<link rel="help" href="https://w3c.github.io/mathml-core/#adjust-space-around-content-mpadded">
<meta name="assert" content="Verify dir attribute on mpadded.">
<link rel="match" href="direction-mpadded-ref.html">
</head>
<body>
<p>
mpadded lspace="25px" width="150px":
<math dir="rtl">
<mspace width="1px" height="25px" mathbackground="black"/>
<mpadded lspace="25px" width="150px">
<mspace width="25px" height="25px" mathbackground="red"/>
<mspace width="25px" height="25px" mathbackground="green"/>
<mspace width="25px" height="25px" mathbackground="blue"/>
</mpadded>
<mspace width="1px" height="25px" mathbackground="black"/>
</math>
</p>

<script src="/mathml/support/feature-detection.js"></script>
<script>MathMLFeatureDetection.ensure_for_match_reftest("has_mspace");</script>
</body>
</html>
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</style>
</head>
<body>
<p>This test passes if you see the same fraction four times.</p>
<p>This test passes if you see the same fraction eight times.</p>
<math>
<mfrac>
<mspace width="20px" height="10px" style="background: blue"></mspace>
Expand All @@ -37,6 +37,26 @@
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac>
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac>
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac>
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac>
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
</math>
</body>
</html>
22 changes: 21 additions & 1 deletion mathml/presentation-markup/fractions/frac-linethickness-001.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</style>
</head>
<body>
<p>This test passes if you see the same fraction four times.</p>
<p>This test passes if you see the same fraction eight times.</p>
<math>
<mfrac linethickness="thin">
<mspace width="20px" height="10px" style="background: blue"></mspace>
Expand All @@ -40,6 +40,26 @@
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac linethickness="100%">
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac linethickness="100%">
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac linethickness="2km">
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
<mspace width="20px"/>
<mfrac linethickness="cat">
<mspace width="20px" height="10px" style="background: blue"></mspace>
<mspace width="20px" height="10px" style="background: cyan"></mspace>
</mfrac>
</math>
<script src="/mathml/support/feature-detection.js"></script>
<script>MathMLFeatureDetection.ensure_for_match_reftest("has_mfrac");</script>
Expand Down

0 comments on commit ecd28aa

Please sign in to comment.