From d49e524e3b9b37c9fb18d1af2e17bbe411c9ac9e Mon Sep 17 00:00:00 2001
From: Joey Arhar <jarhar@chromium.org>
Date: Fri, 5 Apr 2024 02:19:09 -0700
Subject: [PATCH] Rename appearance:bikeshed to appearance:base-select
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

appearance:bikeshed is getting negative feedback for prototyping, so I
am renaming it to base-select even though we don't know that it will be
the final name yet.

Bug: 1511354
Change-Id: I9b6bc228916c8f25af54009644ad135685c7aed3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5421872
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283005}
---
 ...lect-appearance-custom-button-no-datalist.tentative.html | 2 +-
 ...lect-appearance-no-button-custom-datalist.tentative.html | 2 +-
 .../select-appearance-no-button-no-datalist.tentative.html  | 2 +-
 ...ct-child-button-and-datalist-invalidation.tentative.html | 2 +-
 .../select-child-button-and-datalist.tentative.html         | 2 +-
 .../stylable-select/select-keyboard-behavior.tentative.html | 2 +-
 .../stylable-select/select-mouse-behavior.tentative.html    | 6 +++---
 .../stylable-select/selectedoption.tentative.html           | 2 +-
 8 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/html/semantics/forms/the-select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html
index 4e984de2740fe1..94d7fd53b34010 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <button type=popover>one</button>
   <option>one</option>
   <option>two</option>
diff --git a/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html
index 9182395e9e6e64..87425cf7a32116 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <datalist>
     <option>one</option>
     <option>two</option>
diff --git a/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html
index b3e028097b3244..b2a6b5a6d394ba 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <option>one</option>
   <option>two</option>
 </select>
diff --git a/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html
index 6d3419808bd02b..b6d85ac90af35c 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html
@@ -25,7 +25,7 @@
 
 <script>
 requestAnimationFrame(() => {
-  document.querySelector('select').style = 'appearance:bikeshed';
+  document.querySelector('select').style = 'appearance:base-select';
   document.querySelector('button').click();
   document.documentElement.classList.remove('reftest-wait');
 });
diff --git a/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html
index aeb4cd75ac43bd..610861aad8ad9c 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html
@@ -10,7 +10,7 @@
 }
 </style>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <button type=popover>button</button>
   <datalist>
     <option>
diff --git a/html/semantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html
index c53440b8c604cd..2fb11ba68b06dd 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html
@@ -11,7 +11,7 @@
 
 <style>
 select {
-  appearance: bikeshed;
+  appearance: base-select;
 }
 </style>
 
diff --git a/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html
index b9161874b787bc..aff976d1ad5c70 100644
--- a/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html
@@ -11,7 +11,7 @@
 
 <style>
 select {
-  appearance: bikeshed;
+  appearance: base-select;
 }
 </style>
 
@@ -41,7 +41,7 @@
   await test_driver.click(button);
   assert_false(select.matches(':open'),
     'Select should be closed after clicking the button a second time.');
-}, 'Select with appearance:bikeshed should open and close when clicking the button.');
+}, 'Select with appearance:base-select should open and close when clicking the button.');
 
 promise_test(async () => {
   assert_false(select.matches(':open'),
@@ -58,5 +58,5 @@
     'Select should be closed after clicking an option.');
   assert_equals(select.value, 'two',
     'Select.value should be two after clicking the option.');
-}, 'Clicking an option in an appearance:bikeshed select should choose the option and close the popover.');
+}, 'Clicking an option in an appearance:base-select select should choose the option and close the popover.');
 </script>
diff --git a/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html b/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html
index 41ed34a9a2a444..16d711515c931c 100644
--- a/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html
+++ b/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver-vendor.js"></script>
 
 <form>
-  <select style="appearance:bikeshed">
+  <select style="appearance:base-select">
     <button>
       <selectedoption></selectedoption>
     </button>