Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left translations #265

Merged
merged 10 commits into from
Jan 4, 2021
Merged

Add left translations #265

merged 10 commits into from
Jan 4, 2021

Conversation

AndresFelipeCastellanos
Copy link
Collaborator

@AndresFelipeCastellanos AndresFelipeCastellanos commented Dec 18, 2020

Description

Added English translations to the data policy page. Also added Spanish translations to the Grader and Problem Bank plugins, and some left translations to the course administration features.

Partially fixes #182

There are some inner elements on scripts that needs translations. Also need to add remaining Portuguese, German and French translations at Data Policy, course and task administration.

Type of change

Added translations

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@crdgonzalezca crdgonzalezca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes. Looks good.

inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/i18n/es/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
inginious/frontend/plugins/problem_bank/__init__.py Outdated Show resolved Hide resolved
@crdgonzalezca
Copy link
Member

crdgonzalezca commented Dec 24, 2020

LGTM. Please leave a comment in the issue about what there is left to translate in case there is something left, or the other languages that have not been translated. We have chatted about this offline but I do not remember quite well what else this comment must talk about.

@AndresFelipeCastellanos AndresFelipeCastellanos merged commit 68f7c84 into master Jan 4, 2021
@AndresFelipeCastellanos AndresFelipeCastellanos deleted the translations branch January 4, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing translations for different languages
2 participants