Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skipping import of 3rd party store from Epic (or others?) optional #364

Open
ExtremeMultiman opened this issue Feb 9, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@ExtremeMultiman
Copy link

After implementing #355 if I don't use Ubisoft library plugin, games from Epic that use connect will not be imported, that's the same case from EA that generate problems like in #352.

Some of the Ubisoft games will not be seen from connect unless I start it on the source store at least one time (don't remember which one was but it has already happened to me), so I wouldn't have them in my list even with both the libraries.

Also, I might want to have the duplicate to know that I bought games in Epic and/or import metadatas form it automatically on library scan.

An "easy fix" would be having this as an optional setting instead of force library to skip the entry.
Please consider this, regards

@ExtremeMultiman ExtremeMultiman added the enhancement New feature or request label Feb 9, 2024
@jckorlian
Copy link

I second this. Make it optional or use DuplicateHider. It probably also applies to Steam. I need to trust that my library isn't hiding something against my will. The intention was good, but it's causing problems.

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Feb 17, 2024

If that will be added as optional, then maybe few problems will need to be resolved for proper installation and launching.
In case of EA games, problem might be that those games will need to be installed through EA App (Epic launches EA App with install dialog).
However in case of Ubisoft games, if you launch them, then you need to wait for starting Ubisoft Connect, so code for tracking playtime will need to be adjusted. Another small problem is that it still installs Uplay and you need to manually launch it to upgrade to Ubisoft Connect and maybe even update game through Ubisoft Connect.

@ExtremeMultiman
Copy link
Author

It seems to me it is the same problem there is with other kinds of clients like some MMO who have independents launchers on Steam.
Still I would prefer to have a "broken" or duplicate entry (that I can manually fix) that a missing one, but maybe that's just me.

@jckorlian
Copy link

I'm still with Multiman here. The most important thing is that the game shows up in the library immediately where it was purchased. Everything else is secondary. If I forget I own the game before I get to play it in my backlog, the rest doesn't even matter.

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Oct 31, 2024

Ubisoft games should be importable as optional after new update. However in case of EA, only newer games will be imported.
For older ones someone would need to change the way of importing, cuz it's in other api, which includes installable and non installable things (library-service.live.use1a.on.epicgames.com/library/api/public/items).

@ExtremeMultiman
Copy link
Author

First of all thanks for the nice news and your work.

As told before I would prefer to have broken entries than missing ones.
I would find some way to install them and link them to the broken entries (If I can) or choose to hide/remove them manually.

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented Oct 31, 2024

your work

@ExtremeMultiman I only added skipping of new EA games, while optional settings work done by Jhanlon95 and Crow.

broken entries than missing ones

Well, I rather mean that's not just one simple change. However that was rather guideline for other willing dev 😄 .

@ExtremeMultiman
Copy link
Author

Thanks for all the contributors then.
I am also a dev, so I understand it's a lot of work, I actually thought of forking and try doing some modifications myself if I didn't see any changes on this way. I hope my schedule will allow me to do it in the future

hawkeye116477 added a commit to hawkeye116477/playnite-legendary-plugin that referenced this issue Nov 19, 2024
hawkeye116477 added a commit to hawkeye116477/playnite-legendary-plugin that referenced this issue Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants