Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollisionEnded event not sent if collider is removed in the frame following the collision start #348

Open
medeaxiv opened this issue Mar 8, 2024 · 0 comments
Open

CollisionEnded event not sent if collider is removed in the frame following the collision start #348

medeaxiv opened this issue Mar 8, 2024 · 0 comments
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Bug Something isn't working

Comments

@medeaxiv
Copy link

medeaxiv commented Mar 8, 2024

This also leaves dead entries in the CollidingEntities set of the remaining collider.

report_contacts only sends events if the during_previous_frame flag is set on contacts
https://github.com/Jondolf/bevy_xpbd/blob/e9b98d05be9e14086a8b6182d1bb55376cc978e4/src/plugins/collision/contact_reporting.rs#L176-L177

But it looks like the flag is never set to true if one of the colliders is removed in the first frame after the collision
@Jondolf Jondolf added C-Bug Something isn't working A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Collision Relates to the broad phase, narrow phase, colliders, or other collision functionality C-Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jondolf @medeaxiv