Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push upstream into docker machine #29

Closed
LKaemmerling opened this issue May 17, 2019 · 5 comments
Closed

Push upstream into docker machine #29

LKaemmerling opened this issue May 17, 2019 · 5 comments

Comments

@LKaemmerling
Copy link
Contributor

LKaemmerling commented May 17, 2019

Hello guys,

what would you think about pushing this machine driver to docker machine directly so it is "built-in"? https://github.com/docker/machine/tree/master/drivers

Pro: Users won't need to download the driver on there own
Pro: This would be an official docker driver
Pro: Documentation would be available in the Docker docs.

@JonasProgrammer
Copy link
Owner

While it would be cool to see this project make it into upstream docker, I'm not sure we really qualify for official inclusion. We don't have tests at all and the code is mostly undocumented.

Granted, the logic is not very complex, but I doubt the docker people would want something like this in their codebase. Currently I don't have time to get this into an includable state. Perhaps that's something for the semester vacation...

This aspect aside, it actually takes ages to get something accepted into docker. Just listing our driver took more than half a year (see #7). So even if we decide to get this into a state that might be included, you guys shouldn't hold your breath to list hetzner cloud as docker-native any time soon ;)

@mxschmitt
Copy link
Collaborator

I would just go for adding some of our documentation to the official one. Linode for example does this, the driver of them is located in their own repository but the documentation is i the official docs. Or just at least some backlinks.
Reference: https://docs.docker.com/machine/drivers/linode/

@stale
Copy link

stale bot commented Dec 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the no-response Issue was marked stale and no response has been received in time. label Dec 6, 2019
@JonasProgrammer JonasProgrammer self-assigned this Dec 6, 2019
@stale stale bot removed the no-response Issue was marked stale and no response has been received in time. label Dec 6, 2019
@JonasProgrammer JonasProgrammer removed their assignment Dec 6, 2019
@alexandernst
Copy link

Anyways, isn't the docker-machine repo in maintenance-only mode?

@mxschmitt
Copy link
Collaborator

Good catch. Let's close this one. Ref: docker/machine#4537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants