Potential parsing error in _parse_url function.

[drew2a]

I'm not familiar with magnet2torrent, so my assumptions could be incorrect. I've just read the code of the following function:

magnet2torrent/src/magnet2torrent/magnet2torrent.py

Lines 34 to 51 in d3b0704

	def _parse_url(self):
	url = urlparse(self.magnet_link)
	url_query = parse_qs(url.query)
	infohash = url_query["xt"][0].split(":")[2]
	if len(infohash) == 40:
	infohash = binascii.unhexlify(infohash)
	elif len(infohash) == 32:
	infohash = base64.b32decode(infohash)
	else:
	raise Exception("Unable to parse infohash")
	trackers = url_query.get("tr", [])
	name = url_query.get("dn")
	if name:
	name = name[0]
	else:
	name = binascii.hexlify(infohash).decode()
	return infohash, trackers, name

I noticed there might be an issue in the line:

magnet2torrent/src/magnet2torrent/magnet2torrent.py

Line 37 in d3b0704

infohash = url_query["xt"][0].split(":")[2]

As it doesn't differentiate between hash types. It could be urn:sha1, urn:ed2khash, urn:btih, etc. However, only btih is compatible with BitTorrent.

Ref:

• https://fr.wikipedia.org/wiki/Discussion:Magnet_(standard)