Skip to content

Simplify invite token for users #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgielen opened this issue May 16, 2021 · 4 comments
Open

Simplify invite token for users #17

sgielen opened this issue May 16, 2021 · 4 comments

Comments

@sgielen
Copy link
Collaborator

sgielen commented May 16, 2021

Currently, registering to a circle requires four values:

  • circle name
  • username
  • invite token (hash of username + CA private key)
  • URL to public CA cert

We could simplify this by creating a single token that contains all values.

Proposal: The new token starts with the circle name, and contains an encoded version of the username, an expiry date, some checksum of the CA certificate and a hash over these values plus private key produced by discovery earlier. The client can read the username, expiry date & checksum from the token. The client connects to discovery using the circle name, checks that its CA certificate matches the checksum, then passes the encoded value. Discovery can also read the username and expiry date, and check that they were produced by itself by checking against the private key.

@sgielen sgielen changed the title Simplify invite token Simplify invite token for users May 16, 2021
@sgielen sgielen added this to the v1.0 milestone May 16, 2021
@Jille
Copy link
Owner

Jille commented May 16, 2021

Expiring invite tokens seem incompatible with allowing people to self-register multiple devices. Did we have a good idea to solve that yet? (I propose tokens simply don't expire for now.)

@sgielen
Copy link
Collaborator Author

sgielen commented May 16, 2021

Expiring invite tokens seem incompatible with allowing people to self-register multiple devices. Did we have a good idea to solve that yet? (I propose tokens simply don't expire for now.)

Sounds good to me. Let's leave the expiry date out then :)

@Jille Jille removed this from the v1.0 milestone May 16, 2021
@Jille
Copy link
Owner

Jille commented Jun 13, 2021

636315c made progress here: the CA is now a fingerprint rather than needing the full CA certificate (through a file / URL)

@Jille
Copy link
Owner

Jille commented Aug 18, 2024

I think we're gonna solve this with #115 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants