Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW ONLY] - Reallocate styles in appropriate files #713

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Dec 4, 2024

Closes #708

@hamen hamen requested a review from rock3r December 4, 2024 14:08
import org.jetbrains.jewel.ui.component.styling.ButtonMetrics
import org.jetbrains.jewel.ui.component.styling.ButtonStyle

internal fun readOutlinedButtonStyle(): ButtonStyle {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outlined and Default are both Button types. They should stay in the same file (IntUiBridgeButton)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 65116fb

import org.jetbrains.jewel.ui.component.styling.TabStyle
import org.jetbrains.jewel.ui.icons.AllIconsKeys

internal fun readEditorTabStyle(): TabStyle {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default and Editor are both Tab styles. They should stay in the same file (IntUiBridgeTab)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 51d8d29

@hamen hamen requested a review from rock3r December 6, 2024 10:16
@rock3r rock3r added the cleanup Improve the project/tooling and/or get rid of tech debt label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improve the project/tooling and/or get rid of tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move non-Button styles to the right files
2 participants