Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub-bullets remove root bullet #147

Closed
Roboroads opened this issue Dec 13, 2022 · 3 comments · Fixed by #166
Closed

Sub-bullets remove root bullet #147

Roboroads opened this issue Dec 13, 2022 · 3 comments · Fixed by #166
Assignees
@hsz
Labels
bug Something isn't working regression
Milestone
2.1.0

Comments

@Roboroads
Copy link

Roboroads commented Dec 13, 2022 •
edited
Loading

Describe the bug
When patching the changelog (using JetBrains/intellij-platform-plugin-template next branch) the sub-bullets replace the root bullet.

To Reproduce
Create a changelog with sub bullets (actual example from my repo)

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Add way to customize vendor path.
  - Also fixed the bug from this PR where it crashed if you didn't configure anything.
- Add ANSI mode parsing (instead of regex-replace-guessing in the output window)

When patched, the new changelog looks like this:

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [2.5.0]
### Added
- - Also fixed the bug from this PR where it crashed if you didn't configure anything.
- Add ANSI mode parsing (instead of regex-replace-guessing in the output window)

Expected behavior

# Changelog

All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

## [2.5.0]
### Added
- Add way to customize vendor path.
  - Also fixed the bug from this PR where it crashed if you didn't configure anything.
- Add ANSI mode parsing (instead of regex-replace-guessing in the output window)

Environment:

  • OS: Gitlab Runner (Ubuntu)
  • Gradle Changelog Plugin Version 2.0.0
  • Gradle Version 7.5.1
@Roboroads Roboroads added the bug Something isn't working label Dec 13, 2022
GitHubPang added a commit to GitHubPang/Rossynt that referenced this issue Feb 3, 2023
@GitHubPang
Rollback org.jetbrains.changelog to 1.3.1.
58d1f3c 
This is needed because of JetBrains/gradle-changelog-plugin#147
@4ch1m
Copy link

4ch1m commented Feb 6, 2023

I can confirm that bug.

The (valid) markdown is being rendered just fine in the preview:

However, the plugin is rendering this:

@YannCebron
Copy link
Member

YannCebron/m68kplugin@52cf846

since it affected "old" versions I caught it only by accident

YannCebron added a commit to YannCebron/m68kplugin that referenced this issue Mar 4, 2023
@YannCebron
CHANGELOG: restore entries mangled by JetBrains/gradle-changelog-plug…
b8e8395 
…in#147
@JojOatXGME
Copy link
Contributor

I noticed this issue is not specific to (sub-)bullets. The plugin generally seems to skip/remove all but the last paragraph for each bullet. For example,

- AA
- BB

  CC

  DD
- EE

becomes

- AA
- DD
- EE

Roboroads added a commit to Roboroads/laravel-tinker that referenced this issue Apr 16, 2023
@Roboroads
chore: Fixes mangles changelog caused by JetBrains/gradle-changelog-p…
ad83ba9 
…lugin#147
Roboroads added a commit to Roboroads/laravel-tinker that referenced this issue Apr 16, 2023
@github-actions @actions-user @Roboroads
Changelog update - v2.6.0 (#248)
755cc07 
* Changelog update - v2.6.0

* chore: Fixes mangles changelog caused by JetBrains/gradle-changelog-plugin#147

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Robbin "Roboroads" Schepers <[email protected]>
JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this issue Apr 16, 2023
@JojOatXGME
Reformat CHANGELOG.md with new plugin version (WIP wait for JetBrains…
9c6fd30 
…/gradle-changelog-plugin#147)

JetBrains/gradle-changelog-plugin#147
This was referenced Apr 16, 2023
Closed
Merged
@hsz hsz closed this as completed in #166 Jun 1, 2023
@hsz hsz added this to the next milestone Jun 1, 2023
JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this issue Jun 26, 2023
@JojOatXGME
Update changelog plugin to fix :patchChangelog
69a6acc 
See JetBrains/gradle-changelog-plugin#133 and
JetBrains/gradle-changelog-plugin#147.
JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this issue Jun 26, 2023
@JojOatXGME
Update changelog plugin to fix :patchChangelog
3336e57 
See JetBrains/gradle-changelog-plugin#133 and
JetBrains/gradle-changelog-plugin#147.
JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this issue Jun 27, 2023
@JojOatXGME
Update changelog plugin to fix :patchChangelog
539aed0 
See JetBrains/gradle-changelog-plugin#133 and
JetBrains/gradle-changelog-plugin#147.
JojOatXGME added a commit to JojOatXGME/nix-idea that referenced this issue Jun 27, 2023
@JojOatXGME
Update changelog plugin to fix :patchChangelog
a80caa4 
See JetBrains/gradle-changelog-plugin#133 and
JetBrains/gradle-changelog-plugin#147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsz hsz

Labels
bug Something isn't working regression
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Fix handling of multiple nodes within list item JojOatXGME/gradle-changelog-plugin
5 participants
@hsz @YannCebron @JojOatXGME @4ch1m @Roboroads