You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the 'release' workflow, the patched changelog contains CRLF instead of LF and does not have newline at end of file. I think the Gradle task 'patchChangelog' does it.
Also, I've made the .gitattributes file to ensure the correct line ending (KENNYSOFT/IDEA-260828-Korean@b88aa75) but it seems that it's not applied well.
Steps to reproduce:
Write a changelog in the file, and commit it with LF.
Release a new version.
Auto-generated PR contains a change to CRLF.
Expected behavior:
Patch the file with LF, or at least apply the .gitattributes file.
Additional context:
To see the newline character difference, use --ws-error-highlight=all option to the Git command. (e.g., git diff, git show)
The text was updated successfully, but these errors were encountered:
YannCebron
transferred this issue from JetBrains/intellij-platform-plugin-template
Mar 17, 2022
I also noticed the CRLF in the CHANGELOG.md some time ago. The problem still exists in version 2.1.0. The CRLF is not introduced by this plugin, but by GitHub. It looks like the release notes retrieved from GitHub always uses CRLF. The intellij-platform-plugin-template uses patchChangelog --release-note= to replace part of the file with the release notes from GitHub. For nix-idea, I used the following workaround:
tasks.named("patchChangelog") {
// GitHub seems to use CRLF as line feeds.// We have to replace them to avoid files with mixed line endings.
doFirst {
val releaseNote = property("releaseNote")
if (releaseNote isString) {
setProperty("releaseNote", releaseNote.replace("\r\n", "\n"))
}
}
}
Describe the bug:
In the 'release' workflow, the patched changelog contains CRLF instead of LF and does not have newline at end of file. I think the Gradle task 'patchChangelog' does it.
Reference: KENNYSOFT/IDEA-260828-Korean#2
Also, I've made the .gitattributes file to ensure the correct line ending (KENNYSOFT/IDEA-260828-Korean@b88aa75) but it seems that it's not applied well.
Steps to reproduce:
Expected behavior:
Patch the file with LF, or at least apply the .gitattributes file.
Additional context:
To see the newline character difference, use
--ws-error-highlight=all
option to the Git command. (e.g.,git diff
,git show
)The text was updated successfully, but these errors were encountered: