Replace all methods of `promote_type` by `promote_rule` #70

lgoettgens · 2024-06-11T10:26:37Z

Resolves #67.

JeffreySarnoff · 2024-06-11T14:18:34Z

Please add two very simple tests to confirm this change has no unexpected result. (There have been "obvious, non-controversial and simple" PRs in other numerical repos which did.) Then I am delighted to merge, increment the version, and release your patch.

lgoettgens · 2024-06-11T20:13:19Z

The comparison tests in

ArbNumerics.jl/test/compare.jl

Lines 10 to 57 in 1bd8472

    
           @test ArbFloat(2.0) > 1 
        
           @test ArbFloat(2.0) >= 1 
        
           @test 1 < ArbFloat(2.0) 
        
           @test 1 <= ArbFloat(2.0) 
        
           @test ArbFloat(2.0) > 1.0 
        
           @test 1.0 < ArbFloat(2.0) 
        
           @test ArbFloat(2.0) >= 1.0 
        
           @test 1.0 <= ArbFloat(2.0) 
        
           @test ArbFloat(2.0) == ArbFloat(2.0) 
        
           @test ArbFloat(1.0) != ArbFloat(2.0) 
        
           @test ArbFloat(2.0) > ArbFloat(1.0) 
        
           @test ArbFloat(1.0) < ArbFloat(2.0) 
        
           @test ArbFloat(2.0) >= ArbFloat(1.0) 
        
           @test ArbFloat(1.0) <= ArbFloat(2.0) 
        
           @test ArbFloat(2.0) == ArbReal(2.0) 
        
           @test ArbFloat(1.0) != ArbReal(2.0) 
        
           @test ArbFloat(2.0) > ArbReal(1.0) 
        
           @test ArbFloat(1.0) < ArbReal(2.0) 
        
           @test ArbFloat(2.0) >= ArbReal(1.0) 
        
           @test ArbFloat(1.0) <= ArbReal(2.0) 
        
           @test ArbReal(2.0) == ArbFloat(2.0) 
        
           @test ArbReal(1.0) != ArbFloat(2.0) 
        
           @test ArbReal(2.0) > ArbFloat(1.0) 
        
           @test ArbReal(1.0) < ArbFloat(2.0) 
        
           @test ArbReal(2.0) >= ArbFloat(1.0) 
        
           @test ArbReal(1.0) <= ArbFloat(2.0) 
        
           @test ArbReal(2.0) > 1 
        
           @test ArbReal(2.0) >= 1 
        
           @test 1 < ArbReal(2.0) 
        
           @test 1 <= ArbReal(2.0) 
        
           @test ArbReal(2.0) > 1.0 
        
           @test 1.0 < ArbReal(2.0) 
        
           @test ArbReal(2.0) >= 1.0 
        
           @test 1.0 <= ArbReal(2.0) 
        
           @test ArbReal(2.0) == ArbReal(2.0) 
        
           @test ArbReal(1.0) != ArbReal(2.0) 
        
           @test ArbReal(2.0) > ArbReal(1.0) 
        
           @test ArbReal(1.0) < ArbReal(2.0) 
        
           @test ArbReal(2.0) >= ArbReal(1.0) 
        
           @test ArbReal(1.0) <= ArbReal(2.0)

already do a great job in testing that comparisons still hold after promoting. Nevertheless, I added a few small tests that check the expected output type of some basic arithmetic operations. Is this what you had in mind?

JeffreySarnoff · 2024-06-11T22:30:38Z

yes thanks

…

On Tue, Jun 11, 2024 at 10:13 PM Lars Göttgens ***@***.***> wrote: The comparison tests in https://github.com/JeffreySarnoff/ArbNumerics.jl/blob/1bd8472c3bfb2607a3d876fff261f11ce113dc70/test/compare.jl#L10-L57 already do a great job in testing that comparisons still hold after promoting. Nevertheless, I added a few small tests that check the expected output type of some basic arithmetic operations. Is this what you had in mind? — Reply to this email directly, view it on GitHub <#70 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM2VRSHXQL3XBTKFIPEIFDZG5K7LAVCNFSM6AAAAABJEBBPV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGUZTENZZGY> . You are receiving this because you commented.Message ID: ***@***.***>

Replace all methods of promote_type by promote_rule

56edc7c

Add some tests

d6395cf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace all methods of `promote_type` by `promote_rule` #70

Replace all methods of `promote_type` by `promote_rule` #70

lgoettgens commented Jun 11, 2024

JeffreySarnoff commented Jun 11, 2024

lgoettgens commented Jun 11, 2024

JeffreySarnoff commented Jun 11, 2024 via email

Replace all methods of promote_type by promote_rule #70

Are you sure you want to change the base?

Replace all methods of promote_type by promote_rule #70

Conversation

lgoettgens commented Jun 11, 2024

JeffreySarnoff commented Jun 11, 2024

lgoettgens commented Jun 11, 2024

JeffreySarnoff commented Jun 11, 2024 via email

Replace all methods of `promote_type` by `promote_rule` #70

Replace all methods of `promote_type` by `promote_rule` #70